test: cover jsLikeAnalyzer computed object-property-key fallback - #537
Merged
askpt merged 1 commit intoAug 13, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
11 tasks
askpt
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 81.82% 81.85% +0.02%
==========================================
Files 13 13
Lines 4386 4386
Branches 450 450
==========================================
+ Hits 3589 3590 +1
+ Misses 796 795 -1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage for computed object-property keys falling back to (anonymous) in the JavaScript analyzer.
Changes:
- Tests computed-key anonymous function naming.
- Verifies complexity remains correctly calculated.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
askpt
deleted the
repo-assist/test-jslike-computed-key-20260812-a84bc793dd6b204f
branch
August 13, 2026 07:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This pull request was created by Repo Assist, an automated AI assistant.
Summary
Adds a unit test covering
getFunctionNameinjsLikeAnalyzer.tsfor the case where an anonymousfunction_expressionis assigned to a computed object property key (e.g.{ [computedKey]: function() {} }). Previously this branch (line 228:keyNode?.type === "property_identifier" || keyNode?.type === "identifier") was exercised only by the "true" side (bare identifier keys); a computed key correctly falls through to(anonymous), but that fallback path was untested.Rationale
npm run test:coverage(branch coverage forjsLikeAnalyzer.tswas 98.33%, missing branch on line 228).(anonymous)is correct) is locked in by a regression test.Test Status
Coverage improved:
jsLikeAnalyzer.tsbranch coverage 98.33% → 99.17% (line 228 fully covered; remaining gap at line 465 is a pre-existing, likely-defensive fallback ingetOperator, left untouched per minimal-scope guidance).Trade-offs
None — this is a pure test addition with no behavior change.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
releaseassets.githubusercontent.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.
Add this agentic workflow to your repo
To install this agentic workflow, run